Skip to content

Header files error fixed - #29264

Closed
shikharjaiswal-in wants to merge 1 commit into
python:mainfrom
shikharjaiswal-in:main
Closed

shikharjaiswal-in wants to merge 1 commit into
python:mainfrom
shikharjaiswal-in:main

Conversation

@shikharjaiswal-in

Copy link
Copy Markdown

No description provided.

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@shikhar1020jais1

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@da-woods

da-woods commented Nov 1, 2021

Copy link
Copy Markdown
Contributor

It isn't clear what error you believe you've fixed?

It looks to me like this PR:

  • Adds #ifdef __cplusplus extern "C" { #endifguards. These are mostly unnecessary because they're in the files one level out. For example "include/unicodeobject.h" (which includes include/cpython/unicodeobject.h) already has the extern "C"
    #ifdef __cplusplus
    extern "C" {
    #endif
  • Somehow rewrites every line of the file (probably by changing the line endings??).
  • Creates a copy of pyconfig.h in the include directory

@github-actions

github-actions Bot commented Dec 2, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 2, 2021
@github-actions

Copy link
Copy Markdown

Closing this stale PR because the CLA is still not signed.

@github-actions github-actions Bot closed this Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants